[SPARK-21575][SparkR] Eliminate needless synchronization in java-R serialization#18775
Closed
SereneAnt wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
SereneAnt
changed the title
SereneAnt
force-pushed
the
eliminate_unnecessary_synchronization_in_java-R_serialization
branch
from
eafad7d to
aeee08f
Compare
srowen
approved these changes
Jul 30, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Agree. A lock is still acquired, but just the map's lock. Less work is done too. That can help a little.
|
Test build #3863 has finished for PR 18775 at commit
|
Contributor
|
Merged into master, thanks for all. |
SereneAnt
deleted the
eliminate_unnecessary_synchronization_in_java-R_serialization
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove surplus synchronized blocks.
How was this patch tested?
Unit tests run OK.